Remove double decoding in unmarshalSingleValue #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callers of unmarshalSingleValue() always unmarshal
the inputs of this function into `json.RawMessage`.
These `json.RawMessage` contain a valid JSON data
that can be parsed directly. Doing an Unmarshal of
`json.RawMessage` into `json.RawMessage` looks confusing
and not very useful.
This change is mostly about the readability and code clarity.
As a side note, it also improves `sjson` unmarshalling performance.
name old time/op new time/op delta
Array/array_all/UnmarshalJSON-8 34.6µs ± 1% 21.7µs ± 1% -37.36% (p=0.000 n=10+9)
Document/all/UnmarshalJSON-8 120µs ± 0% 77µs ± 1% -36.04% (p=0.000 n=9+10)
[Geo mean] 64.5µs 40.8µs -36.70%
name old speed new speed delta
Array/array_all/UnmarshalJSON-8 1.62MB/s ± 1% 2.58MB/s ± 1% ~ (p=0.000 n=10+9)
Document/all/UnmarshalJSON-8 2.15MB/s ± 1% 3.37MB/s ± 1% +56.37% (p=0.000 n=9+10)
[Geo mean] 1.87MB/s 2.95MB/s +57.97%
name old alloc/op new alloc/op delta
Array/array_all/UnmarshalJSON-8 41.4kB ± 0% 22.0kB ± 0% -46.92% (p=0.000 n=10+10)
Document/all/UnmarshalJSON-8 117kB ± 0% 62kB ± 0% -46.89% (p=0.000 n=10+10)
[Geo mean] 69.6kB 37.0kB -46.91%
name old allocs/op new allocs/op delta
Array/array_all/UnmarshalJSON-8 184 ± 0% 119 ± 0% -35.33% (p=0.000 n=10+10)
Document/all/UnmarshalJSON-8 580 ± 0% 374 ± 0% -35.52% (p=0.000 n=10+10)
[Geo mean] 327 211 -35.42%
quasilyte
requested review from
AlekSi,
chilagrow,
a team,
rumyantseva and
noisersup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
+ Coverage 72.72% 76.22% +3.50%
==========================================
Files 382 385 +3
Lines 20815 21060 +245
==========================================
+ Hits 15137 16054 +917
+ Misses 4730 4080 -650
+ Partials 948 926 -22
... and 82 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
quasilyte
changed the title
rumyantseva
approved these changes
Jul 10, 2023
AlekSi
approved these changes
Jul 10, 2023
AlekSi
added
code/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The callers of unmarshalSingleValue() always unmarshal the inputs of this function into
json.RawMessage.These
json.RawMessagecontain valid JSON datathat can be parsed directly. Doing an Unmarshal of
json.RawMessageintojson.RawMessagelooks confusing and not very useful.This change is mostly about readability and code clarity.
As a side note, it also improves
sjsonunmarshalling performance.Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.