Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect renameCollection tests failures #3007

Merged
merged 10 commits into from
Jul 11, 2023
Merged

Expect renameCollection tests failures #3007

merged 10 commits into from
Jul 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 7, 2023 •
edited
Loading

Description

Add helper for SQLite tests.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 7, 2023
@AlekSi AlekSi added this to the Next milestone Jul 7, 2023
@AlekSi AlekSi self-assigned this Jul 7, 2023
@AlekSi AlekSi changed the title Expert renameCollection test failure Expect renameCollection test failure Jul 7, 2023
@AlekSi AlekSi changed the title Expect renameCollection test failure Expect renameCollection tests failures Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #3007 (3ef9f90) into main (0c0f463) will increase coverage by 0.17%.
The diff coverage is 82.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
+ Coverage   76.15%   76.33%   +0.17%     
==========================================
  Files         386      386              
  Lines       21056    21075      +19     
==========================================
+ Hits        16036    16088      +52     
+ Misses       4096     4068      -28     
+ Partials      924      919       -5
Impacted Files Coverage Δ
...nternal/util/iterator/testiterator/testiterator.go 100.00% <ø> (ø)
internal/util/testutil/testfail/expected.go 69.38% <60.00%> (ø)
integration/setup/test_helpers.go 100.00% <100.00%> (ø)
internal/util/testutil/teststress/stress.go 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.84% <82.60%> (+0.14%) ⬆️
mongodb 5.39% <39.13%> (+0.05%) ⬆️
pg 66.26% <60.86%> (+0.02%) ⬆️
shard-1 56.08% <82.60%> (+0.16%) ⬆️
shard-2 54.63% <21.73%> (-0.04%) ⬇️
shard-3 56.49% <36.95%> (-0.08%) ⬇️
sqlite 46.46% <80.43%> (+0.13%) ⬆️
unit 24.28% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from a team, rumyantseva, quasilyte, chilagrow and noisersup July 7, 2023 07:23
@AlekSi AlekSi marked this pull request as ready for review July 7, 2023 07:23
@AlekSi AlekSi enabled auto-merge (squash) July 7, 2023 07:23
@AlekSi AlekSi marked this pull request as draft July 7, 2023 07:24
auto-merge was automatically disabled July 7, 2023 07:24

Pull request was converted to draft

@AlekSi
Copy link
Member Author

AlekSi commented Jul 7, 2023

Uh, sorry, I should not push broken commit right before the takeoff :D

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 11, 2023
@AlekSi
Merge branch 'main' into xfail-sqlite-tests
96c0efa 
# Conflicts:
#	integration/setup/test_helpers.go
#	internal/util/testutil/testfail/expected.go
#	internal/util/testutil/testtb/tb.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 11, 2023
@AlekSi AlekSi removed request for a team July 11, 2023 11:31
@AlekSi AlekSi marked this pull request as ready for review July 11, 2023 11:34
@AlekSi AlekSi requested a review from a team as a code owner July 11, 2023 11:34
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 11, 2023 11:34
@AlekSi AlekSi enabled auto-merge (squash) July 11, 2023 11:34
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 11, 2023 11:34
@AlekSi AlekSi mentioned this pull request Jul 11, 2023
Merged
9 tasks
rumyantseva
rumyantseva approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

noisersup
noisersup approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 9fc79b6 into FerretDB:main Jul 11, 2023
@AlekSi AlekSi deleted the xfail-sqlite-tests branch July 11, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@quasilyte quasilyte Awaiting requested review from quasilyte quasilyte was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup