Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a copy of the testing.TB interface #2987

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 5, 2023

Description

It will be used by the next PR.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

It will be used by the next PR.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 5, 2023
@AlekSi AlekSi added this to the Next milestone Jul 5, 2023
@AlekSi AlekSi self-assigned this Jul 5, 2023
@AlekSi AlekSi requested a review from a team as a code owner July 5, 2023 12:20
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup July 5, 2023 12:20
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2987 (7f1cf50) into main (78cfe4e) will increase coverage by 0.01%.
The diff coverage is 87.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   68.78%   68.80%   +0.01%     
==========================================
  Files         451      451              
  Lines       24107    24107              
==========================================
+ Hits        16582    16586       +4     
+ Misses       6499     6498       -1     
+ Partials     1026     1023       -3     
Impacted Files Coverage Δ
internal/util/testutil/hexdump.go 20.00% <0.00%> (ø)
integration/setup/listener.go 71.67% <66.66%> (ø)
internal/util/testutil/dump.go 45.45% <66.66%> (ø)
internal/util/testutil/equal.go 58.44% <80.00%> (ø)
integration/setup/setup.go 74.09% <83.33%> (ø)
integration/helpers.go 83.08% <94.44%> (ø)
integration/setup/client.go 70.96% <100.00%> (ø)
integration/setup/setup_compat.go 80.88% <100.00%> (ø)
integration/setup/test_helpers.go 93.02% <100.00%> (ø)
internal/util/testutil/db.go 90.47% <100.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 62.63% <80.95%> (+0.01%) ⬆️
mongodb 4.84% <57.14%> (ø)
pg 57.29% <76.19%> (ø)
shard-1 42.68% <73.01%> (ø)
shard-2 50.71% <68.25%> (ø)
shard-3 46.53% <68.25%> (ø)
sqlite 36.40% <76.19%> (+0.01%) ⬆️
unit 24.23% <61.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlekSi AlekSi requested a review from quasilyte July 5, 2023 12:44
@AlekSi AlekSi enabled auto-merge (squash) July 5, 2023 12:47
@AlekSi AlekSi merged commit 6b1a032 into FerretDB:main Jul 5, 2023
@AlekSi AlekSi deleted the interface-copy branch July 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants