Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move find and aggregation cursor integration tests to getMore #2952

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Move find and aggregation cursor integration tests to getMore #2952

merged 7 commits into from
Jul 4, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 3, 2023 •
edited
Loading

Description

Closes #1733.

  • Moves TestQueryBatchSize from query_test.go to TestGetMoreCommand in getmore_test.go
  • Merges TestQueryBatchSize in query_test.go and TestAggregateBatchSize in aggregate_documents_test.go to TestGetMoreBatchSizeCursor in getmore_test.go

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jul 3, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #2952 (54a83a6) into main (f939bd2) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
- Coverage   64.05%   63.98%   -0.07%     
==========================================
  Files         451      451              
  Lines       24107    24107              
==========================================
- Hits        15441    15425      -16     
- Misses       7704     7718      +14     
- Partials      962      964       +2

see 3 files with indirect coverage changes

Flag Coverage Δ
integration 57.29% <ø> (-0.11%) ⬇️
mongodb ?
pg 57.29% <ø> (-0.04%) ⬇️
shard-1 42.44% <ø> (+0.51%) ⬆️
shard-2 45.61% <ø> (+3.34%) ⬆️
shard-3 41.48% <ø> (-4.60%) ⬇️
unit 24.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 3, 2023 04:01
@chilagrow chilagrow requested a review from a team as a code owner July 3, 2023 04:01
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, w84thesun and noisersup July 3, 2023 04:01
@chilagrow chilagrow enabled auto-merge (squash) July 3, 2023 04:01
@AlekSi AlekSi added this to the Next milestone Jul 3, 2023
w84thesun
w84thesun approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rumyantseva
rumyantseva approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit cbd9e06 into FerretDB:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Support getMore command
5 participants
@chilagrow @w84thesun @rumyantseva @noisersup @AlekSi