Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insert documents type validation #2946

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Add insert documents type validation #2946

merged 4 commits into from
Jun 30, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jun 30, 2023 •
edited
Loading

Description

Found this while working on reimplementing delete command.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun self-assigned this Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #2946 (837bf20) into main (11a2389) will decrease coverage by 4.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   63.96%   59.97%   -4.00%     
==========================================
  Files         451      451              
  Lines       24070    24074       +4     
==========================================
- Hits        15397    14438     -959     
- Misses       7712     8646     +934     
- Partials      961      990      +29
Impacted Files Coverage Δ
internal/handlers/common/insert.go 100.00% <100.00%> (ø)
internal/handlers/pg/msg_insert.go 88.42% <100.00%> (+4.76%) ⬆️

... and 48 files with indirect coverage changes

Flag Coverage Δ
integration 53.01% <100.00%> (-4.39%) ⬇️
mongodb 4.91% <0.00%> (+0.07%) ⬆️
pg 52.80% <100.00%> (-4.53%) ⬇️
shard-1 4.91% <0.00%> (-36.87%) ⬇️
shard-2 42.31% <100.00%> (+0.12%) ⬆️
shard-3 46.03% <40.00%> (-0.01%) ⬇️
unit 24.13% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jun 30, 2023
@w84thesun w84thesun marked this pull request as ready for review June 30, 2023 13:40
@w84thesun w84thesun requested a review from a team as a code owner June 30, 2023 13:40
@w84thesun w84thesun requested review from AlekSi and rumyantseva June 30, 2023 13:40
@w84thesun w84thesun enabled auto-merge (squash) June 30, 2023 13:40
@w84thesun w84thesun requested review from a team, chilagrow and noisersup and removed request for AlekSi June 30, 2023 13:40
rumyantseva
rumyantseva approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

noisersup
noisersup approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@w84thesun w84thesun merged commit 206abe8 into FerretDB:main Jun 30, 2023
@w84thesun w84thesun deleted the add-insert-docs-validation branch June 30, 2023 16:13
@AlekSi AlekSi added this to the v1.5.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@w84thesun @rumyantseva @noisersup @AlekSi