Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement killCursors command #2939

Merged
merged 21 commits into from
Jul 6, 2023
Merged

Implement killCursors command #2939

merged 21 commits into from
Jul 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 29, 2023 •
edited
Loading

Description

Closes #1514.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 29, 2023
@AlekSi AlekSi added this to the Next milestone Jun 29, 2023
@AlekSi AlekSi self-assigned this Jun 29, 2023
@AlekSi AlekSi modified the milestones: v1.5.0, Next Jul 3, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 3, 2023
@AlekSi AlekSi marked this pull request as ready for review July 3, 2023 16:56
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners July 3, 2023 16:56
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 3, 2023 16:56
@AlekSi AlekSi enabled auto-merge (squash) July 3, 2023 16:56
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #2939 (bf9e927) into main (6b1a032) will decrease coverage by 6.49%.
The diff coverage is 72.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
- Coverage   68.82%   62.33%   -6.49%     
==========================================
  Files         451      457       +6     
  Lines       24107    24224     +117     
==========================================
- Hits        16591    15100    -1491     
- Misses       6494     8084    +1590     
- Partials     1022     1040      +18
Impacted Files Coverage Δ
...ternal/handlers/commoncommands/msg_listcommands.go 0.00% <ø> (-100.00%) ⬇️
internal/handlers/hana/msg_killcursors.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_killcursors.go 0.00% <0.00%> (ø)
internal/util/testutil/xfail.go 61.22% <61.22%> (ø)
internal/handlers/common/killcursors.go 80.00% <80.00%> (ø)
integration/helpers.go 82.46% <100.00%> (-0.63%) ⬇️
integration/setup/test_helpers.go 92.85% <100.00%> (-0.17%) ⬇️
internal/handlers/pg/msg_killcursors.go 100.00% <100.00%> (ø)
internal/handlers/sqlite/msg_killcursors.go 100.00% <100.00%> (ø)

... and 52 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 55.90% <67.44%> (-6.75%) ⬇️
mongodb 4.82% <3.87%> (-0.02%) ⬇️
pg 50.50% <62.79%> (-6.79%) ⬇️
shard-1 47.74% <37.20%> (+5.05%) ⬆️
shard-2 ∅ <ø> (∅)
shard-3 48.05% <65.11%> (+1.52%) ⬆️
sqlite 36.55% <63.56%> (+0.12%) ⬆️
unit 24.21% <19.67%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 4, 2023
chilagrow
chilagrow reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment 🤗

internal/handlers/common/killcursors.go Show resolved Hide resolved
rumyantseva
rumyantseva previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Show resolved Hide resolved
@AlekSi
Merge branch 'main' into kill-cursors
7cb2830 
# Conflicts:
#	integration/query_test.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 5, 2023
@AlekSi
Merge branch 'main' into kill-cursors
990ad66 
# Conflicts:
#	integration/helpers.go
#	integration/setup/test_helpers.go
#	internal/util/testutil/xfail.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 5, 2023
chilagrow
chilagrow reviewed Jul 6, 2023
View reviewed changes
internal/handlers/common/killcursors.go Show resolved Hide resolved
integration/query_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi requested review from rumyantseva, chilagrow, quasilyte, a team and noisersup July 6, 2023 08:13
chilagrow
chilagrow approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go by me!

rumyantseva
rumyantseva approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge July 6, 2023 08:24
@AlekSi AlekSi merged commit 708d90a into FerretDB:main Jul 6, 2023
@AlekSi AlekSi deleted the kill-cursors branch July 6, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@quasilyte quasilyte Awaiting requested review from quasilyte

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Implement killCursors command
4 participants
@AlekSi @rumyantseva @quasilyte @chilagrow