Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better metrics for connections #2938

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Add better metrics for connections #2938

merged 2 commits into from
Jun 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 29, 2023

Description

Makes debugging a bit easier.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 29, 2023
@AlekSi AlekSi added this to the Next milestone Jun 29, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 29, 2023 04:27
@AlekSi AlekSi self-assigned this Jun 29, 2023
@AlekSi AlekSi requested review from rumyantseva and chilagrow June 29, 2023 04:27
@AlekSi AlekSi enabled auto-merge (squash) June 29, 2023 04:27
@AlekSi AlekSi requested review from a team, w84thesun and noisersup June 29, 2023 04:27
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #2938 (588de40) into main (d3fd02a) will increase coverage by 0.05%.
The diff coverage is 82.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
+ Coverage   64.14%   64.20%   +0.05%     
==========================================
  Files         451      451              
  Lines       23888    23914      +26     
==========================================
+ Hits        15323    15353      +30     
+ Misses       7603     7598       -5     
- Partials      962      963       +1
Impacted Files Coverage Δ
internal/clientconn/connmetrics/conn_metrics.go 93.15% <ø> (+4.10%) ⬆️
internal/handlers/hana/hana.go 0.00% <ø> (ø)
internal/handlers/pg/pg.go 75.00% <ø> (ø)
internal/handlers/registry/hana.go 7.69% <0.00%> (ø)
internal/handlers/registry/registry.go 55.55% <ø> (ø)
internal/handlers/registry/sqlite.go 6.25% <0.00%> (ø)
internal/handlers/registry/tigris.go 5.00% <0.00%> (ø)
internal/handlers/sqlite/msg_serverstatus.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/sqlite.go 0.00% <ø> (ø)
internal/handlers/tigris/msg_serverstatus.go 0.00% <0.00%> (ø)
... and 11 more
Flag Coverage Δ
integration 57.58% <81.42%> (+0.06%) ⬆️
mongodb 4.82% <37.14%> (+0.27%) ⬆️
pg 57.52% <81.42%> (+0.06%) ⬆️
shard-1 42.44% <81.42%> (+0.08%) ⬆️
shard-2 45.60% <81.42%> (-0.03%) ⬇️
shard-3 42.38% <81.42%> (+0.08%) ⬆️
unit 24.26% <55.38%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

w84thesun
w84thesun approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit 5f0ddcb into FerretDB:main Jun 29, 2023
@AlekSi AlekSi deleted the more-metrics branch June 29, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @chilagrow