Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper response for createIndexes #2936

Merged
merged 15 commits into from
Jun 30, 2023
Merged

Implement proper response for createIndexes #2936

merged 15 commits into from
Jun 30, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Jun 28, 2023 •
edited
Loading

Description

Closes #2845.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 28, 2023
@rumyantseva rumyantseva self-assigned this Jun 28, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Jun 28, 2023
@chilagrow chilagrow mentioned this pull request Jun 30, 2023
Closed
9 tasks
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #2936 (6f65848) into main (a5cc636) will increase coverage by 0.01%.
The diff coverage is 88.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   64.27%   64.28%   +0.01%     
==========================================
  Files         451      451              
  Lines       23951    23961      +10     
==========================================
+ Hits        15394    15404      +10     
  Misses       7595     7595              
  Partials      962      962
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/indexes.go 75.48% <66.66%> (+0.48%) ⬆️
internal/handlers/pg/pgdb/collections.go 71.20% <85.71%> (+0.46%) ⬆️
internal/handlers/pg/msg_createindexes.go 86.34% <100.00%> (+0.14%) ⬆️
internal/handlers/pg/msg_listindexes.go 72.36% <100.00%> (+0.36%) ⬆️
internal/handlers/pg/msg_update.go 77.57% <100.00%> (+0.21%) ⬆️
internal/handlers/pg/pgdb/insert.go 82.22% <100.00%> (-0.39%) ⬇️
Flag Coverage Δ
integration 57.69% <88.23%> (+0.01%) ⬆️
mongodb 4.86% <0.00%> (-0.01%) ⬇️
pg 57.62% <88.23%> (+0.01%) ⬆️
shard-1 43.03% <67.64%> (+0.87%) ⬆️
shard-2 42.04% <79.41%> (-1.06%) ⬇️
shard-3 45.89% <76.47%> (-0.05%) ⬇️
unit 24.25% <35.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review June 30, 2023 09:26
@rumyantseva rumyantseva requested a review from a team as a code owner June 30, 2023 09:26
@rumyantseva rumyantseva requested review from AlekSi and chilagrow June 30, 2023 09:26
@rumyantseva rumyantseva enabled auto-merge (squash) June 30, 2023 09:26
@rumyantseva rumyantseva requested a review from a team June 30, 2023 09:26
@rumyantseva
Copy link
Contributor Author

Please review the changes themselves while I'm fixing the linter in tests 🙏

@AlekSi AlekSi removed their request for review June 30, 2023 09:27
chilagrow
chilagrow previously approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

integration/indexes_command_compat_test.go Outdated Show resolved Hide resolved
w84thesun
w84thesun previously approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva dismissed stale reviews from chilagrow and w84thesun via 6f65848 June 30, 2023 12:27
@rumyantseva
Copy link
Contributor Author

Fixed the tests! Please take another look 🙏

noisersup
noisersup approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one small comment

internal/handlers/pg/msg_createindexes.go Show resolved Hide resolved
w84thesun
w84thesun approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rumyantseva rumyantseva added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 30, 2023
@AlekSi AlekSi disabled auto-merge June 30, 2023 14:31
@AlekSi AlekSi merged commit a2d3e43 into FerretDB:main Jun 30, 2023
@AlekSi AlekSi added this to the v1.5.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Implement proper response for createIndexes
5 participants
@rumyantseva @w84thesun @chilagrow @noisersup @AlekSi