Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests after bumping deps #2934

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix integration tests after bumping deps #2934

merged 2 commits into from
Jun 28, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 28, 2023 •
edited
Loading

Description

Removed the test as it tests driver and not the database.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Jun 28, 2023
@noisersup noisersup added the code/chore Code maintenance improvements label Jun 28, 2023
@noisersup noisersup marked this pull request as ready for review June 28, 2023 11:27
@noisersup noisersup requested a review from a team as a code owner June 28, 2023 11:27
@noisersup noisersup requested review from AlekSi, w84thesun, a team, rumyantseva and chilagrow June 28, 2023 11:27
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2934 (b3d66ab) into main (81312f9) will increase coverage by 6.24%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   57.72%   63.97%   +6.24%     
==========================================
  Files         451      451              
  Lines       23847    23847              
==========================================
+ Hits        13765    15255    +1490     
+ Misses       9113     7628    -1485     
+ Partials      969      964       -5

see 58 files with indirect coverage changes

Flag Coverage Δ
integration 57.35% <ø> (+6.65%) ⬆️
mongodb 4.34% <ø> (?)
pg 57.27% <ø> (+6.57%) ⬆️
shard-1 41.97% <ø> (+0.31%) ⬆️
shard-2 44.08% <ø> (?)
shard-3 43.01% <ø> (ø)
unit 23.99% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup mentioned this pull request Jun 28, 2023
Merged
10 tasks
AlekSi
AlekSi reviewed Jun 28, 2023
View reviewed changes
integration/basic_test.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from AlekSi June 28, 2023 11:41
@noisersup noisersup enabled auto-merge (squash) June 28, 2023 11:46
rumyantseva
rumyantseva approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! It answers the exact question I was about to ask :)

@noisersup noisersup merged commit ed330f7 into FerretDB:main Jun 28, 2023
@noisersup noisersup deleted the fix-after-bump branch June 28, 2023 12:24
@AlekSi AlekSi added this to the v1.5.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@noisersup @AlekSi @rumyantseva