Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cursors in find command #2933

Merged
merged 15 commits into from
Jun 29, 2023
Merged

Use cursors in find command #2933

merged 15 commits into from
Jun 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 28, 2023 •
edited
Loading

Description

Closes #1733.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 28, 2023
@AlekSi AlekSi added this to the Next milestone Jun 28, 2023
@AlekSi AlekSi self-assigned this Jun 28, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2933 (c3bd646) into main (7b6ccf3) will increase coverage by 0.09%.
The diff coverage is 77.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
+ Coverage   64.04%   64.14%   +0.09%     
==========================================
  Files         451      451              
  Lines       23861    23888      +27     
==========================================
+ Hits        15282    15323      +41     
+ Misses       7616     7603      -13     
+ Partials      963      962       -1
Impacted Files Coverage Δ
internal/handlers/pg/msg_dropdatabase.go 60.52% <0.00%> (-7.13%) ⬇️
internal/handlers/sqlite/msg_drop.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_dropdatabase.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_find.go 0.00% <0.00%> (ø)
internal/handlers/pg/pgdb/transactions.go 86.07% <84.00%> (+15.65%) ⬆️
internal/handlers/pg/msg_drop.go 68.18% <100.00%> (+3.18%) ⬆️
internal/handlers/pg/msg_find.go 85.00% <100.00%> (+3.84%) ⬆️
internal/handlers/pg/pgdb/pool.go 69.46% <100.00%> (ø)
internal/handlers/pg/pgdb/query_iterator.go 85.00% <100.00%> (+1.66%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 57.52% <72.22%> (+0.07%) ⬆️
mongodb 4.55% <0.00%> (-0.01%) ⬇️
pg 57.45% <72.22%> (+0.07%) ⬆️
shard-1 42.36% <72.22%> (+0.07%) ⬆️
shard-2 45.52% <65.27%> (-0.21%) ⬇️
shard-3 42.30% <65.27%> (+0.08%) ⬆️
unit 24.24% <40.27%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 28, 2023 18:04
@AlekSi AlekSi requested a review from a team as a code owner June 28, 2023 18:04
@AlekSi AlekSi requested review from w84thesun and rumyantseva June 28, 2023 18:04
@AlekSi AlekSi enabled auto-merge (squash) June 28, 2023 18:05
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 28, 2023 18:05
w84thesun
w84thesun previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi mentioned this pull request Jun 28, 2023
Closed
3 tasks
chilagrow
chilagrow reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question so I understand it 🤗

internal/handlers/pg/pgdb/transactions.go Show resolved Hide resolved
internal/handlers/pg/msg_find.go Show resolved Hide resolved
@AlekSi AlekSi requested review from w84thesun, chilagrow and a team June 29, 2023 04:12
@AlekSi
Copy link
Member Author

AlekSi commented Jun 29, 2023

@chilagrow PTAL

chilagrow
chilagrow approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi disabled auto-merge June 29, 2023 05:20
@AlekSi AlekSi merged commit d3fd02a into FerretDB:main Jun 29, 2023
@AlekSi AlekSi deleted the use-cursors-in-find branch June 29, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Support getMore command
3 participants
@AlekSi @w84thesun @chilagrow