Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmark to use cursors #2932

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Update benchmark to use cursors #2932

merged 4 commits into from
Jun 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 28, 2023

Description

We are not interested in benchmarking driver's decoding speed.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Update benchmark to use cursors
f9ee456 
We are not interested in benchmarking driver's decoding speed.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 28, 2023
@AlekSi AlekSi added this to the Next milestone Jun 28, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 28, 2023 08:26
@AlekSi AlekSi self-assigned this Jun 28, 2023
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team, w84thesun and noisersup June 28, 2023 08:26
@AlekSi AlekSi enabled auto-merge (squash) June 28, 2023 08:26
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2932 (405fd9a) into main (81312f9) will not change coverage.
The diff coverage is n/a.

❗ Current head 405fd9a differs from pull request most recent head a61938e. Consider uploading reports for the commit a61938e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2932   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files         451      451           
  Lines       23847    23847           
=======================================
  Hits        13765    13765           
  Misses       9113     9113           
  Partials      969      969
Flag Coverage Δ
integration 50.70% <ø> (ø)
pg 50.70% <ø> (ø)
shard-1 41.66% <ø> (ø)
shard-3 43.01% <ø> (ø)
unit 24.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 28, 2023
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 28, 2023
noisersup
noisersup approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

rumyantseva
rumyantseva approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge June 28, 2023 12:28
@AlekSi AlekSi merged commit 6161e73 into FerretDB:main Jun 28, 2023
@AlekSi AlekSi deleted the benchmark-cursors branch June 28, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @noisersup