Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps, add permissions monitoring #2930

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Bump deps, add permissions monitoring #2930

merged 5 commits into from
Jun 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 28, 2023 •
edited
Loading

Description

To stay current.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added deps PRs that update dependencies trust PRs that can access Actions secrets labels Jun 28, 2023
@AlekSi AlekSi added this to the Next milestone Jun 28, 2023
@AlekSi AlekSi self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2930 (e9df305) into main (5b1e6b6) will decrease coverage by 6.29%.
The diff coverage is n/a.

❗ Current head e9df305 differs from pull request most recent head 0421d2d. Consider uploading reports for the commit 0421d2d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2930      +/-   ##
==========================================
- Coverage   64.00%   57.72%   -6.29%     
==========================================
  Files         451      451              
  Lines       23847    23847              
==========================================
- Hits        15264    13765    -1499     
- Misses       7618     9113    +1495     
- Partials      965      969       +4

see 58 files with indirect coverage changes

Flag Coverage Δ
integration 50.70% <ø> (-6.66%) ⬇️
mongodb ?
pg 50.70% <ø> (-6.58%) ⬇️
shard-1 41.65% <ø> (-0.33%) ⬇️
shard-2 ?
shard-3 43.01% <ø> (+0.10%) ⬆️
unit 24.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 28, 2023 07:57
@AlekSi AlekSi enabled auto-merge (squash) June 28, 2023 07:58
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup June 28, 2023 07:58
chilagrow
chilagrow previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

.github/workflows/clean.yml Outdated Show resolved Hide resolved
noisersup
noisersup previously approved these changes Jun 28, 2023
View reviewed changes
@AlekSi AlekSi dismissed stale reviews from noisersup and chilagrow via 0421d2d June 28, 2023 08:24
@AlekSi AlekSi requested review from noisersup, chilagrow and a team June 28, 2023 08:24
chilagrow
chilagrow approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi disabled auto-merge June 28, 2023 08:50
@AlekSi AlekSi merged commit 483f927 into FerretDB:main Jun 28, 2023
@AlekSi AlekSi deleted the actions-and-deps branch June 28, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@AlekSi AlekSi

Labels
deps PRs that update dependencies trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @w84thesun @chilagrow @noisersup