Convert SQLite directory to URI #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2922 +/- ##
==========================================
+ Coverage 63.99% 64.04% +0.05%
==========================================
Files 451 451
Lines 24074 24108 +34
==========================================
+ Hits 15407 15441 +34
+ Misses 7707 7705 -2
- Partials 960 962 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
added 17 commits
June 29, 2023 09:45
chilagrow
reviewed
Jun 30, 2023
chilagrow
reviewed
Jun 30, 2023
added 2 commits
June 30, 2023 09:12
…FerretDB into issue-2753-sqlite-uri
chilagrow
previously approved these changes
Jun 30, 2023
AlekSi
requested changes
Jun 30, 2023
| if err != nil { | ||
| return nil, lazyerrors.Error(err) | ||
| } | ||
|
|
||
| p := &Pool{ | ||
| dir: dir, | ||
| dir: uri.Path, |
There was a problem hiding this comment.
🛑 And after that, we lose query parameters that we should pass to openDB below, as well in GetOrCreate via databasePath and maybe somewhere else
There was a problem hiding this comment.
Saved uri instead of dir.
There was a problem hiding this comment.
That does not change the fact that openDB accepts matched files (without query parameters) in one place and the database path (also without query parameters) in another.
added 3 commits
June 30, 2023 17:22
chilagrow
previously approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2753.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.