Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collection name starting with dot validation #2912

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix collection name starting with dot validation #2912

merged 2 commits into from
Jun 26, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 26, 2023 •
edited
Loading

Description

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Jun 26, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@noisersup noisersup marked this pull request as ready for review June 26, 2023 12:15
@noisersup noisersup requested a review from a team as a code owner June 26, 2023 12:15
@noisersup noisersup force-pushed the fix-collection-dot branch from 3a946b0 to cc9620d Compare June 26, 2023 12:17
@noisersup noisersup added code/bug Some user-visible feature works incorrectly code/enhancement Some user-visible feature could work better and removed code/bug Some user-visible feature works incorrectly labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #2912 (bd3872b) into main (eb6170c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
+ Coverage   63.61%   63.66%   +0.05%     
==========================================
  Files         451      451              
  Lines       23577    23583       +6     
==========================================
+ Hits        14999    15015      +16     
+ Misses       7610     7602       -8     
+ Partials      968      966       -2
Impacted Files Coverage Δ
internal/handlers/pg/msg_create.go 73.75% <100.00%> (+1.02%) ⬆️
internal/handlers/pg/pgdb/collections.go 70.73% <100.00%> (+0.73%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 56.94% <100.00%> (+0.05%) ⬆️
mongodb 4.39% <0.00%> (-0.01%) ⬇️
pg 56.85% <100.00%> (+0.05%) ⬆️
shard-1 41.99% <0.00%> (-0.02%) ⬇️
shard-2 45.30% <100.00%> (+0.06%) ⬆️
shard-3 40.64% <0.00%> (+<0.01%) ⬆️
unit 24.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup requested review from a team and w84thesun June 26, 2023 12:22
@noisersup noisersup enabled auto-merge (squash) June 26, 2023 12:22
@AlekSi AlekSi added this to the Next milestone Jun 26, 2023
@AlekSi AlekSi self-requested a review June 26, 2023 12:23
w84thesun
w84thesun approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noisersup noisersup merged commit 49d338c into FerretDB:main Jun 26, 2023
@noisersup noisersup deleted the fix-collection-dot branch June 26, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@noisersup @CLAassistant @AlekSi @w84thesun