Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellation signals propagation #2908

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 26, 2023

Description

This PR uncovers a problem with resource tracking that the next PR will fix.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 26, 2023
@AlekSi AlekSi added this to the Next milestone Jun 26, 2023
@AlekSi AlekSi self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2908 (058bdf0) into main (362758a) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   63.62%   63.61%   -0.01%     
==========================================
  Files         451      451              
  Lines       23570    23577       +7     
==========================================
+ Hits        14996    14999       +3     
- Misses       7606     7610       +4     
  Partials      968      968              
Impacted Files Coverage Δ
ferretdb/ferretdb.go 83.33% <ø> (-0.33%) ⬇️
integration/setup/listener.go 62.00% <ø> (-0.26%) ⬇️
internal/util/testutil/testutil.go 78.04% <64.00%> (-21.96%) ⬇️
integration/setup/setup.go 69.78% <100.00%> (ø)
internal/clientconn/listener.go 72.90% <100.00%> (+0.68%) ⬆️
internal/util/resource/resource.go 82.14% <100.00%> (+14.28%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.88% <75.00%> (+<0.01%) ⬆️
mongodb 4.39% <50.00%> (-0.02%) ⬇️
pg 56.80% <72.22%> (+<0.01%) ⬆️
shard-1 42.00% <75.00%> (+0.02%) ⬆️
shard-2 45.23% <72.22%> (+0.01%) ⬆️
shard-3 40.64% <72.22%> (-0.01%) ⬇️
unit 24.26% <69.69%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 26, 2023 09:57
@AlekSi AlekSi requested a review from a team as a code owner June 26, 2023 09:57
@AlekSi AlekSi requested review from w84thesun and rumyantseva June 26, 2023 09:57
@AlekSi AlekSi enabled auto-merge (squash) June 26, 2023 09:57
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 26, 2023 09:57
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit eb6170c into FerretDB:main Jun 26, 2023
@AlekSi AlekSi deleted the context-propagation branch June 26, 2023 10:29
@AlekSi AlekSi changed the title Fix cancelation signals propagation Fix cancellation signals propagation Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants