Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement DELETE for SQLite backend #2907

Merged
merged 54 commits into from
Jun 30, 2023
Merged

Re-implement DELETE for SQLite backend #2907

merged 54 commits into from
Jun 30, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jun 26, 2023 •
edited
Loading

Description

Delete tests passed locally.

Closes #2751.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jun 26, 2023
@w84thesun w84thesun self-assigned this Jun 26, 2023
@w84thesun w84thesun added not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged and removed do not merge PRs that should not be merged labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #2907 (1a0c84b) into main (a2d3e43) will decrease coverage by 4.17%.
The diff coverage is 3.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   64.28%   60.11%   -4.17%     
==========================================
  Files         451      451              
  Lines       23961    24066     +105     
==========================================
- Hits        15404    14468     -936     
- Misses       7595     8614    +1019     
- Partials      962      984      +22
Impacted Files Coverage Δ
internal/backends/collection.go 0.00% <ø> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/handlers/common/delete.go 100.00% <ø> (ø)
internal/handlers/sqlite/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_delete.go 83.73% <100.00%> (+0.13%) ⬆️

... and 41 files with indirect coverage changes

Flag Coverage Δ
integration 53.40% <3.44%> (-4.29%) ⬇️
mongodb 4.84% <0.00%> (-0.03%) ⬇️
pg 53.23% <3.44%> (-4.39%) ⬇️
shard-1 41.79% <1.72%> (-1.14%) ⬇️
shard-2 ?
shard-3 46.04% <3.44%> (+0.15%) ⬆️
unit 24.14% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 26, 2023
@w84thesun w84thesun marked this pull request as ready for review June 26, 2023 16:55
@w84thesun w84thesun requested review from AlekSi and a team as code owners June 26, 2023 16:55
@w84thesun w84thesun requested a review from chilagrow June 26, 2023 16:55
@w84thesun w84thesun enabled auto-merge (squash) June 26, 2023 16:55
@w84thesun w84thesun requested review from a team, rumyantseva and noisersup June 26, 2023 16:55
chilagrow
chilagrow reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, few comments 🤗

internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_delete.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_delete.go Show resolved Hide resolved
AlekSi
AlekSi reviewed Jun 27, 2023
View reviewed changes
internal/backends/sqlite/collection.go Show resolved Hide resolved
internal/backends/sqlite/collection.go Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from noisersup June 28, 2023 18:19
chilagrow
chilagrow previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

AlekSi
AlekSi reviewed Jun 29, 2023
View reviewed changes
integration/delete_command_compat_test.go Outdated Show resolved Hide resolved
integration/delete_command_compat_test.go Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested review from chilagrow and AlekSi June 29, 2023 08:37
chilagrow
chilagrow approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi added this to the Next milestone Jun 30, 2023
@w84thesun w84thesun merged commit e78942e into FerretDB:main Jun 30, 2023
@w84thesun w84thesun deleted the issue-2751-sqlite-delete branch June 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Re-implement DELETE for SQLite backend
5 participants
@w84thesun @AlekSi @rumyantseva @chilagrow @noisersup