Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wire and sjson fuzzing #2883

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Improve wire and sjson fuzzing #2883

merged 3 commits into from
Jun 22, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 22, 2023 •
edited
Loading

Description

Cleanup wire package.
Make sjson fuzzing load recorded messages.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 22, 2023
@AlekSi AlekSi added this to the Next milestone Jun 22, 2023
@AlekSi AlekSi self-assigned this Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #2883 (fee54fe) into main (0c6f3a5) will decrease coverage by 0.10%.
The diff coverage is 15.15%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   63.45%   63.36%   -0.10%     
==========================================
  Files         451      451              
  Lines       23417    23465      +48     
==========================================
+ Hits        14860    14869       +9     
- Misses       7591     7630      +39     
  Partials      966      966
Impacted Files Coverage Δ
internal/wire/bits.go 100.00% <ø> (ø)
internal/wire/op_msg.go 57.26% <ø> (ø)
internal/wire/record.go 14.28% <14.28%> (ø)
internal/wire/msg_body.go 47.05% <33.33%> (ø)
Flag Coverage Δ
integration 56.54% <1.51%> (-0.12%) ⬇️
mongodb 4.16% <0.00%> (-0.01%) ⬇️
pg 56.46% <1.51%> (-0.12%) ⬇️
shard-1 40.85% <1.51%> (-0.09%) ⬇️
shard-2 41.66% <1.51%> (-0.09%) ⬇️
shard-3 45.03% <1.51%> (+<0.01%) ⬆️
unit 24.39% <15.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 22, 2023 07:29
@AlekSi AlekSi requested a review from a team as a code owner June 22, 2023 07:29
@AlekSi AlekSi requested review from w84thesun and rumyantseva June 22, 2023 07:29
@AlekSi AlekSi enabled auto-merge (squash) June 22, 2023 07:29
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 22, 2023 07:29
noisersup
noisersup approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlekSi
AlekSi commented Jun 22, 2023
View reviewed changes
Taskfile.yml Show resolved Hide resolved
@AlekSi AlekSi requested a review from rumyantseva June 22, 2023 13:50
rumyantseva
rumyantseva approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit ced4756 into FerretDB:main Jun 22, 2023
@AlekSi AlekSi deleted the fuzz-sjson branch June 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup