Add basic tests for iterators #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
===========================================
- Coverage 64.19% 49.75% -14.45%
===========================================
Files 448 450 +2
Lines 23084 23125 +41
===========================================
- Hits 14819 11506 -3313
- Misses 7299 10652 +3353
- Partials 966 967 +1
... and 82 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
reviewed
Jun 21, 2023
rumyantseva
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
I like the idea of moving this separate Stress logic into a separate function! One suggestion - maybe in our test naming convention we should mention that there are those Stress tests and how they should be named. Could be in the same PR where the existing tests will use the new Stress function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.