Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzing corpus collection #2879

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Fix fuzzing corpus collection #2879

merged 2 commits into from
Jun 21, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 21, 2023

Description

Upload fuzzing corpus as an artifact if fuzzing failed for PR (when secrets are not available).
Fix broken corpus collection due to changed Go internals.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 21, 2023
@AlekSi AlekSi added this to the Next milestone Jun 21, 2023
@AlekSi AlekSi self-assigned this Jun 21, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 21, 2023 10:16
@AlekSi AlekSi requested review from w84thesun and chilagrow June 21, 2023 10:16
@AlekSi AlekSi enabled auto-merge (squash) June 21, 2023 10:16
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup June 21, 2023 10:17
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2879 (ea5c253) into main (f5edff7) will decrease coverage by 4.26%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   64.19%   59.93%   -4.26%     
==========================================
  Files         448      448              
  Lines       23084    23084              
==========================================
- Hits        14819    13836     -983     
- Misses       7299     8266     +967     
- Partials      966      982      +16     

see 42 files with indirect coverage changes

Flag Coverage Δ
integration 52.91% <ø> (-4.52%) ⬇️
mongodb 4.22% <ø> (ø)
pg 52.64% <ø> (-4.71%) ⬇️
shard-1 41.57% <ø> (+0.10%) ⬆️
shard-2 ?
shard-3 45.71% <ø> (-0.04%) ⬇️
unit 24.59% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading is a good idea!

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit c68c936 into FerretDB:main Jun 21, 2023
@AlekSi AlekSi deleted the fix-fuzzing branch June 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants