Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported commands #2876

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Update supported commands #2876

merged 4 commits into from
Jun 21, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 21, 2023 •
edited by AlekSi
Loading

Description

Applying recent changes of implemented aggregation to supported commands

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the documentation Something user-visible is badly or not documented label Jun 21, 2023
@chilagrow chilagrow self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #2876 (2f58fe0) into main (c68c936) will decrease coverage by 6.67%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
- Coverage   64.19%   57.53%   -6.67%     
==========================================
  Files         448      448              
  Lines       23084    23084              
==========================================
- Hits        14819    13281    -1538     
- Misses       7299     8819    +1520     
- Partials      966      984      +18

see 48 files with indirect coverage changes

Flag Coverage Δ
integration 50.24% <ø> (-7.15%) ⬇️
mongodb 4.22% <ø> (ø)
pg 50.10% <ø> (-7.21%) ⬇️
shard-1 41.46% <ø> (-0.02%) ⬇️
shard-2 42.28% <ø> (ø)
shard-3 ?
unit 24.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review June 21, 2023 04:51
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup June 21, 2023 04:52
@chilagrow chilagrow enabled auto-merge (squash) June 21, 2023 04:52
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Jun 21, 2023
@AlekSi AlekSi added this to the Next milestone Jun 21, 2023
rumyantseva
rumyantseva approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chilagrow chilagrow merged commit 24683b6 into FerretDB:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup