Unify tests for indexes #2866
Merged
Unify tests for indexes #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
==========================================
- Coverage 64.30% 59.92% -4.39%
==========================================
Files 448 448
Lines 23023 23023
==========================================
- Hits 14806 13797 -1009
- Misses 7252 8246 +994
- Partials 965 980 +15 see 42 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
9 tasks
noisersup
approved these changes
Jun 20, 2023
chilagrow
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same variable names, order, error checks, etc, as in other tests. Close cursors.
That prevents tests from panicking with SQLite (
assertwas used whererequireshould be).Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.