Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement count for SQLite #2865

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Implement count for SQLite #2865

merged 2 commits into from
Jun 21, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 20, 2023

Description

Also, optimize count for PostgreSQL.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jun 20, 2023
@AlekSi AlekSi added this to the Next milestone Jun 20, 2023
@AlekSi AlekSi self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #2865 (fdf5404) into main (e653182) will decrease coverage by 14.65%.
The diff coverage is 4.47%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2865       +/-   ##
===========================================
- Coverage   64.30%   49.66%   -14.65%     
===========================================
  Files         448      448               
  Lines       23023    23084       +61     
===========================================
- Hits        14806    11465     -3341     
- Misses       7252    10652     +3400     
- Partials      965      967        +2
Impacted Files Coverage Δ
internal/handlers/common/count_iterator.go 0.00% <ø> (-96.67%) ⬇️
internal/handlers/pg/msg_count.go 0.00% <0.00%> (-73.22%) ⬇️
internal/handlers/sqlite/msg_count.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_update.go 0.00% <0.00%> (ø)
internal/types/array.go 59.63% <0.00%> (-27.29%) ⬇️
internal/types/document.go 87.67% <100.00%> (-3.19%) ⬇️

... and 78 files with indirect coverage changes

Flag Coverage Δ
integration 41.47% <0.00%> (-16.02%) ⬇️
mongodb 4.22% <0.00%> (-0.02%) ⬇️
pg 41.14% <0.00%> (-16.26%) ⬇️
shard-1 41.47% <0.00%> (-0.12%) ⬇️
shard-2 ?
shard-3 ?
unit 24.62% <4.47%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 20, 2023 15:16
@AlekSi AlekSi requested a review from a team as a code owner June 20, 2023 15:16
@AlekSi AlekSi requested review from rumyantseva and chilagrow June 20, 2023 15:16
@AlekSi AlekSi enabled auto-merge (squash) June 20, 2023 15:16
@AlekSi AlekSi requested review from a team, w84thesun and noisersup June 20, 2023 15:16
@AlekSi AlekSi mentioned this pull request Jun 20, 2023
Merged
9 tasks
rumyantseva
rumyantseva reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a couple of comments.

internal/types/document.go Show resolved Hide resolved
internal/handlers/sqlite/msg_count.go Show resolved Hide resolved
@AlekSi AlekSi requested a review from rumyantseva June 20, 2023 18:00
chilagrow
chilagrow approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

rumyantseva
rumyantseva approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 9d75840 into FerretDB:main Jun 21, 2023
@AlekSi AlekSi deleted the count branch June 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow