Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unimplemented-non-default tag usages #2848

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jun 15, 2023

Description

The description of the unimplemented-non-default tag was updated but usage was not.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jun 15, 2023
@w84thesun w84thesun added this to the Next milestone Jun 15, 2023
@w84thesun w84thesun changed the title Fix unimplemented-non-default tag Fix unimplemented-non-default tag usages Jun 15, 2023
@w84thesun w84thesun marked this pull request as ready for review June 15, 2023 17:00
@w84thesun w84thesun requested a review from a team as a code owner June 15, 2023 17:00
@w84thesun w84thesun requested review from AlekSi and rumyantseva June 15, 2023 17:00
@w84thesun w84thesun enabled auto-merge (squash) June 15, 2023 17:00
@w84thesun w84thesun requested review from a team, chilagrow and noisersup June 15, 2023 17:00
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #2848 (46ce773) into main (1ab2bf7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
+ Coverage   63.86%   63.94%   +0.08%     
==========================================
  Files         445      445              
  Lines       22734    22734              
==========================================
+ Hits        14518    14537      +19     
+ Misses       7261     7244      -17     
+ Partials      955      953       -2     
Impacted Files Coverage Δ
internal/handlers/common/find.go 100.00% <ø> (ø)
internal/handlers/commonparams/extract_params.go 82.54% <100.00%> (ø)

... and 4 files with indirect coverage changes

Flag Coverage Δ
integration 57.05% <100.00%> (+0.08%) ⬆️
mongodb 4.98% <0.00%> (?)
pg 56.96% <100.00%> (ø)
shard-1 41.59% <100.00%> (+0.44%) ⬆️
shard-2 44.88% <100.00%> (ø)
shard-3 42.61% <100.00%> (ø)
unit 24.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@w84thesun w84thesun merged commit 16465cd into FerretDB:main Jun 16, 2023
@w84thesun w84thesun deleted the fix-unimplemented branch June 16, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants