Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tests deadlock when backend is down #2846

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Prevent tests deadlock when backend is down #2846

merged 2 commits into from
Jun 15, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 15, 2023 •
edited
Loading

Description

Checked manually.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets labels Jun 15, 2023
@AlekSi AlekSi added this to the Next milestone Jun 15, 2023
@AlekSi AlekSi self-assigned this Jun 15, 2023
@AlekSi AlekSi marked this pull request as ready for review June 15, 2023 11:03
@AlekSi AlekSi requested a review from a team as a code owner June 15, 2023 11:03
@AlekSi AlekSi requested review from w84thesun and chilagrow June 15, 2023 11:03
@AlekSi AlekSi enabled auto-merge (squash) June 15, 2023 11:03
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup June 15, 2023 11:03
@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #2846 (04f8298) into main (263c3fe) will increase coverage by 6.73%.
The diff coverage is 53.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2846      +/-   ##
==========================================
+ Coverage   57.20%   63.94%   +6.73%     
==========================================
  Files         445      445              
  Lines       22727    22734       +7     
==========================================
+ Hits        13002    14537    +1535     
+ Misses       8785     7244    -1541     
- Partials      940      953      +13
Impacted Files Coverage Δ
integration/setup/client.go 81.25% <0.00%> (-1.29%) ⬇️
integration/setup/listener.go 62.25% <72.72%> (-0.51%) ⬇️

... and 40 files with indirect coverage changes

Flag Coverage Δ
integration 57.05% <53.33%> (+7.15%) ⬆️
mongodb 4.98% <0.00%> (-0.01%) ⬇️
pg 56.96% <53.33%> (+7.19%) ⬆️
shard-1 41.59% <53.33%> (+0.11%) ⬆️
shard-2 44.88% <53.33%> (?)
shard-3 42.61% <53.33%> (+<0.01%) ⬆️
unit 24.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 15, 2023
noisersup
noisersup approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi merged commit 1ab2bf7 into FerretDB:main Jun 15, 2023
@AlekSi AlekSi deleted the check-connection branch June 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @noisersup