Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running single test with task #2832

Merged
merged 15 commits into from
Jun 13, 2023
Merged

Fix running single test with task #2832

merged 15 commits into from
Jun 13, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jun 13, 2023 •
edited
Loading

Description

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jun 13, 2023
@w84thesun w84thesun self-assigned this Jun 13, 2023
@w84thesun w84thesun added this to the Next milestone Jun 13, 2023
@w84thesun w84thesun marked this pull request as ready for review June 13, 2023 12:09
@w84thesun w84thesun requested a review from AlekSi as a code owner June 13, 2023 12:09
@w84thesun w84thesun enabled auto-merge (squash) June 13, 2023 12:09
@w84thesun w84thesun requested review from a team, rumyantseva, chilagrow and noisersup June 13, 2023 12:09
@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #2832 (903c432) into main (9536bab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2832   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         442      442           
  Lines       22602    22602           
=======================================
  Hits        14447    14447           
  Misses       7207     7207           
  Partials      948      948
Flag Coverage Δ
integration 56.98% <ø> (ø)
mongodb 5.01% <ø> (ø)
pg 56.90% <ø> (ø)
shard-1 43.73% <ø> (-0.12%) ⬇️
shard-2 43.88% <ø> (+0.01%) ⬆️
shard-3 42.33% <ø> (ø)
unit 25.10% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi reviewed Jun 13, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Jun 13, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Dmitry and others added 3 commits June 13, 2023 14:04
@AlekSi
Update CONTRIBUTING.md
d4badef 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
WIP
963fff3
WIP
3be51e7
@w84thesun w84thesun requested a review from AlekSi June 13, 2023 13:21
AlekSi
AlekSi reviewed Jun 13, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi June 13, 2023 13:40
AlekSi
AlekSi previously approved these changes Jun 13, 2023
View reviewed changes
AlekSi
AlekSi reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run bin/task env-pull fmt-yaml

@w84thesun w84thesun requested a review from AlekSi June 13, 2023 14:00
noisersup
noisersup approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w84thesun w84thesun merged commit 89d6562 into FerretDB:main Jun 13, 2023
@w84thesun w84thesun deleted the fix-running-single-test branch June 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@w84thesun @AlekSi @noisersup