Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getWholeParamStrict and GetScaleParam functions #2831

Merged
merged 15 commits into from
Jun 15, 2023
Merged

Refactor getWholeParamStrict and GetScaleParam functions #2831

merged 15 commits into from
Jun 15, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jun 13, 2023 •
edited
Loading

Description

Closes #2812.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jun 13, 2023
@w84thesun w84thesun self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #2831 (285472e) into main (d4fa206) will increase coverage by 6.84%.
The diff coverage is 81.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
+ Coverage   57.10%   63.95%   +6.84%     
==========================================
  Files         444      445       +1     
  Lines       22519    22727     +208     
==========================================
+ Hits        12860    14534    +1674     
+ Misses       8791     7241    -1550     
- Partials      868      952      +84
Impacted Files Coverage Δ
internal/handlers/tigris/msg_collstats.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_dbstats.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_dbstats.go 73.68% <83.33%> (ø)
...l/handlers/common/aggregations/stages/collstats.go 84.74% <100.00%> (+0.81%) ⬆️
internal/handlers/commonparams/extract_params.go 82.54% <100.00%> (+10.54%) ⬆️
internal/handlers/commonparams/params.go 93.12% <100.00%> (+0.69%) ⬆️
internal/handlers/pg/msg_collstats.go 69.69% <100.00%> (ø)

... and 94 files with indirect coverage changes

Flag Coverage Δ
integration 57.05% <81.25%> (-0.06%) ⬇️
mongodb 4.98% <0.00%> (+<0.01%) ⬆️
pg 56.97% <81.25%> (-0.06%) ⬇️
shard-1 41.47% <47.91%> (+0.08%) ⬆️
shard-2 44.88% <54.16%> (+0.07%) ⬆️
shard-3 42.61% <81.25%> (-0.07%) ⬇️
unit 24.93% <6.25%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun changed the title Refactor parameters functions Refactor getWholeParamStrict and GetScaleParam functions Jun 13, 2023
@w84thesun w84thesun added this to the Next milestone Jun 13, 2023
@w84thesun w84thesun marked this pull request as ready for review June 13, 2023 16:51
@w84thesun w84thesun requested a review from a team as a code owner June 13, 2023 16:51
@w84thesun w84thesun enabled auto-merge (squash) June 13, 2023 16:51
@w84thesun w84thesun requested review from a team and noisersup June 13, 2023 16:52
chilagrow
chilagrow previously approved these changes Jun 14, 2023
View reviewed changes
internal/handlers/commonparams/params.go Outdated Show resolved Hide resolved
chilagrow
chilagrow approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

noisersup
noisersup approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@w84thesun w84thesun merged commit 263c3fe into FerretDB:main Jun 15, 2023
@w84thesun w84thesun deleted the refactor-params branch June 15, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Refactor getParam functions
4 participants
@w84thesun @rumyantseva @chilagrow @noisersup