Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing docs #2828

Merged
merged 8 commits into from
Jun 21, 2023
Merged

Update contributing docs #2828

merged 8 commits into from
Jun 21, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 13, 2023 •
edited
Loading

Description

To kick FerretDB/engineering#63 forward.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 13, 2023
@AlekSi AlekSi self-assigned this Jun 13, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements do not merge PRs that should not be merged and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 21, 2023
@AlekSi AlekSi added this to the Next milestone Jun 21, 2023
@AlekSi AlekSi marked this pull request as ready for review June 21, 2023 05:24
@AlekSi AlekSi enabled auto-merge (squash) June 21, 2023 05:24
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup June 21, 2023 05:24
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #2828 (ba2b11f) into main (643b387) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
- Coverage   56.91%   56.89%   -0.03%     
==========================================
  Files         451      451              
  Lines       23417    23417              
==========================================
- Hits        13327    13322       -5     
- Misses       9107     9111       +4     
- Partials      983      984       +1

see 2 files with indirect coverage changes

Flag Coverage Δ
integration 49.61% <ø> (ø)
mongodb 4.17% <ø> (ø)
pg 49.47% <ø> (ø)
shard-1 40.93% <ø> (-0.02%) ⬇️
shard-2 41.75% <ø> (ø)
unit 24.45% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow reviewed Jun 21, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AlekSi AlekSi mentioned this pull request Jun 21, 2023
Merged
9 tasks
@AlekSi AlekSi requested a review from chilagrow June 21, 2023 05:36
rumyantseva
rumyantseva approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noisersup
noisersup approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment for the future consideration

CONTRIBUTING.md Show resolved Hide resolved
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 21, 2023
@AlekSi AlekSi merged commit f4bb3f3 into FerretDB:main Jun 21, 2023
@AlekSi AlekSi deleted the contrib-docs branch June 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup