Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for find/getMore batchSize #2825

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Add tests for find/getMore batchSize #2825

merged 11 commits into from
Jun 12, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 9, 2023 •
edited
Loading

Description

Closes #2005.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jun 9, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jun 9, 2023
chilagrow
chilagrow commented Jun 9, 2023
View reviewed changes
integration/query_test.go Outdated Show resolved Hide resolved
@chilagrow chilagrow marked this pull request as ready for review June 9, 2023 09:00
@chilagrow chilagrow requested a review from a team as a code owner June 9, 2023 09:00
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, w84thesun and noisersup June 9, 2023 09:00
@chilagrow chilagrow enabled auto-merge (squash) June 9, 2023 09:01
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #2825 (219db82) into main (439fc69) will decrease coverage by 3.94%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
- Coverage   63.79%   59.85%   -3.94%     
==========================================
  Files         442      442              
  Lines       22523    22529       +6     
==========================================
- Hits        14368    13485     -883     
- Misses       7216     8088     +872     
- Partials      939      956      +17
Impacted Files Coverage Δ
integration/helpers.go 84.52% <100.00%> (+0.37%) ⬆️

... and 38 files with indirect coverage changes

Flag Coverage Δ
integration 52.39% <100.00%> (-4.49%) ⬇️
mongodb 5.03% <100.00%> (+0.02%) ⬆️
pg 52.30% <100.00%> (-4.49%) ⬇️
shard-1 42.51% <100.00%> (-0.16%) ⬇️
shard-2 44.74% <100.00%> (+0.10%) ⬆️
shard-3 ?
unit 25.19% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun reviewed Jun 9, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, added a small question about the comment.

integration/query_test.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from w84thesun June 12, 2023 00:51
@chilagrow chilagrow mentioned this pull request Jun 12, 2023
Closed
7 tasks
@chilagrow chilagrow changed the title Add skipped tests for find batchSize Add tests for find/getMore batchSize Jun 12, 2023
rumyantseva
rumyantseva approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases look reasonable to me! I expect we might need to test some more things in the future, but it's hard to predict now, so it looks good for the beginning!

w84thesun
w84thesun approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chilagrow chilagrow merged commit 513efa6 into FerretDB:main Jun 12, 2023
@AlekSi AlekSi added this to the v1.4.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Improve find/getMore batchSize/singleBatch handling
4 participants
@chilagrow @w84thesun @rumyantseva @AlekSi