Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add textlint rules for en dashes and em dashes #2823

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Add textlint rules for en dashes and em dashes #2823

merged 2 commits into from
Jun 9, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 8, 2023 •
edited
Loading

Description

So we don't document –handler or —handler instead of --handler.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 8, 2023
@AlekSi AlekSi added this to the Next milestone Jun 8, 2023
@AlekSi AlekSi self-assigned this Jun 8, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Jun 8, 2023
@AlekSi AlekSi mentioned this pull request Jun 8, 2023
Merged
9 tasks
@AlekSi AlekSi marked this pull request as ready for review June 8, 2023 17:59
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners June 8, 2023 17:59
@AlekSi AlekSi requested review from rumyantseva, chilagrow and Fashander and removed request for rumyantseva and chilagrow June 8, 2023 17:59
@AlekSi AlekSi added the do not merge PRs that should not be merged label Jun 8, 2023
@AlekSi AlekSi enabled auto-merge (squash) June 8, 2023 18:00
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #2823 (4a44c7b) into main (c2fd309) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2823      +/-   ##
==========================================
+ Coverage   63.75%   63.79%   +0.03%     
==========================================
  Files         442      442              
  Lines       22523    22523              
==========================================
+ Hits        14359    14368       +9     
+ Misses       7226     7216      -10     
- Partials      938      939       +1
Impacted Files Coverage Δ
internal/bson/document.go 49.37% <0.00%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 56.83% <0.00%> (ø)
mongodb 5.00% <0.00%> (ø)
pg 56.74% <0.00%> (ø)
shard-1 43.22% <0.00%> (ø)
shard-2 44.63% <0.00%> (ø)
shard-3 41.58% <0.00%> (+0.19%) ⬆️
unit 25.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 9, 2023
@AlekSi AlekSi disabled auto-merge June 9, 2023 04:16
@AlekSi AlekSi merged commit 0f8f663 into FerretDB:main Jun 9, 2023
@AlekSi AlekSi deleted the dashes branch June 9, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @Fashander