-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe current test naming conventions in the contributing guidelines #2821
Describe current test naming conventions in the contributing guidelines #2821
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
=======================================
Coverage 63.79% 63.79%
=======================================
Files 442 442
Lines 22523 22523
=======================================
Hits 14368 14368
Misses 7216 7216
Partials 939 939
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have those guidelines!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! No changes needed except the one above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…myantseva/FerretDB into engineering-66-current-naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Closes FerretDB/engineering#66.
It's a part of the main issue, based on the outcome of #2816.
This PR only describes the current guidelines. The new guidelines will be added in separate PRs together with the changes to meet these new guidelines.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.