Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe current test naming conventions in the contributing guidelines #2821

Merged
merged 14 commits into from
Jun 9, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Jun 8, 2023

Description

Closes FerretDB/engineering#66.

It's a part of the main issue, based on the outcome of #2816.
This PR only describes the current guidelines. The new guidelines will be added in separate PRs together with the changes to meet these new guidelines.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Jun 8, 2023
@rumyantseva rumyantseva added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements and removed documentation Something user-visible is badly or not documented labels Jun 8, 2023
@rumyantseva rumyantseva marked this pull request as ready for review June 8, 2023 14:42
@rumyantseva rumyantseva requested review from a team and AlekSi as code owners June 8, 2023 14:42
@rumyantseva rumyantseva requested a review from w84thesun June 8, 2023 14:42
@rumyantseva rumyantseva enabled auto-merge (squash) June 8, 2023 14:42
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup June 8, 2023 14:46
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2821 (323def3) into main (0f8f663) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2821   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files         442      442           
  Lines       22523    22523           
=======================================
  Hits        14368    14368           
  Misses       7216     7216           
  Partials      939      939           
Flag Coverage Δ
integration 56.83% <ø> (ø)
mongodb 5.00% <ø> (ø)
pg 56.74% <ø> (ø)
shard-1 42.46% <ø> (-0.77%) ⬇️
shard-2 44.52% <ø> (-0.23%) ⬇️
shard-3 42.67% <ø> (+1.29%) ⬆️
unit 25.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have those guidelines!

integration/indexes_compat_test.go Outdated Show resolved Hide resolved
noisersup
noisersup previously approved these changes Jun 8, 2023
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! No changes needed except the one above.

noisersup
noisersup previously approved these changes Jun 8, 2023
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

w84thesun
w84thesun previously approved these changes Jun 8, 2023
@rumyantseva rumyantseva dismissed stale reviews from w84thesun and noisersup via 1e8cfd7 June 9, 2023 06:32
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi added this to the Next milestone Jun 9, 2023
@rumyantseva rumyantseva merged commit 345488d into FerretDB:main Jun 9, 2023
@rumyantseva rumyantseva deleted the engineering-66-current-naming branch June 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants