Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shard integration tests #2820

Merged
merged 9 commits into from
Jun 8, 2023
Merged

Shard integration tests #2820

merged 9 commits into from
Jun 8, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 8, 2023 •
edited
Loading

Description

This PR improves, simplifies, and refactors sharding logic, and hooks it into CI.

Branch protection rules should be updated, hence do not merge PRs that should not be merged .

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements do not merge PRs that should not be merged labels Jun 8, 2023
@AlekSi AlekSi added this to the Next milestone Jun 8, 2023
@AlekSi AlekSi self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #2820 (1d966ad) into main (38776c6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2820   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files         442      442           
  Lines       22523    22523           
=======================================
  Hits        14368    14368           
  Misses       7216     7216           
  Partials      939      939
Flag Coverage Δ
integration 56.83% <ø> (ø)
mongodb 5.00% <ø> (ø)
pg 56.74% <ø> (ø)
shard-1 43.22% <ø> (?)
shard-2 44.62% <ø> (?)
shard-3 41.38% <ø> (?)
unit 25.19% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 8, 2023 13:38
@AlekSi AlekSi requested a review from a team as a code owner June 8, 2023 13:38
@AlekSi AlekSi requested review from rumyantseva and chilagrow June 8, 2023 13:38
@AlekSi AlekSi enabled auto-merge (squash) June 8, 2023 13:38
@AlekSi AlekSi requested review from a team, w84thesun and noisersup June 8, 2023 13:50
rumyantseva
rumyantseva approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Looking forward to seeing it in action!

noisersup
noisersup approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 8, 2023
@AlekSi AlekSi merged commit c2fd309 into FerretDB:main Jun 8, 2023
@AlekSi AlekSi deleted the shard-tests branch June 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup