Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check error message in non compat integration tests #2806

Merged
merged 15 commits into from
Jun 8, 2023
Merged

Check error message in non compat integration tests #2806

merged 15 commits into from
Jun 8, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 7, 2023 •
edited
Loading

Description

Closes #2599.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #2806 (42eda13) into main (1c1c435) will increase coverage by 37.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2806       +/-   ##
===========================================
+ Coverage   26.71%   63.79%   +37.07%     
===========================================
  Files         442      442               
  Lines       22519    22523        +4     
===========================================
+ Hits         6016    14368     +8352     
+ Misses      15886     7216     -8670     
- Partials      617      939      +322
Impacted Files Coverage Δ
integration/helpers.go 84.14% <100.00%> (+37.45%) ⬆️

... and 143 files with indirect coverage changes

Flag Coverage Δ
integration 56.83% <100.00%> (+51.82%) ⬆️
mongodb 5.00% <50.00%> (-0.01%) ⬇️
pg 56.74% <100.00%> (?)
unit 25.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Refactor integration tests Check error message in non compat integration tests Jun 7, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jun 7, 2023
@chilagrow chilagrow marked this pull request as ready for review June 7, 2023 10:19
@chilagrow chilagrow requested a review from a team as a code owner June 7, 2023 10:19
@chilagrow chilagrow requested review from AlekSi, w84thesun, a team, rumyantseva and noisersup June 7, 2023 10:19
@chilagrow chilagrow enabled auto-merge (squash) June 7, 2023 10:19
@chilagrow chilagrow mentioned this pull request Jun 7, 2023
Merged
9 tasks
rumyantseva
rumyantseva reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job bringing consistency to all the tests!

I left a couple of quite minor suggestions/questions (feel free to disagree).

w84thesun
w84thesun reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Added several suggestions about identical altMessages.

integration/distinct_test.go Show resolved Hide resolved
integration/commands_freemonitoring_test.go Show resolved Hide resolved
integration/commands_diagnostic_test.go Show resolved Hide resolved
integration/commands_administration_test.go Show resolved Hide resolved
integration/aggregate_documents_test.go Show resolved Hide resolved
integration/findandmodify_test.go Show resolved Hide resolved
integration/indexes_test.go Show resolved Hide resolved
integration/query_array_test.go Show resolved Hide resolved
integration/query_test.go Show resolved Hide resolved
integration/query_test.go Show resolved Hide resolved
rumyantseva
rumyantseva approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and one more (big) step towards more consistent tests!

w84thesun
w84thesun approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noisersup
noisersup approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Looks good to me

@chilagrow chilagrow merged commit 38776c6 into FerretDB:main Jun 8, 2023
@AlekSi AlekSi added this to the v1.4.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Do check error messages in non-compat integration tests
5 participants
@chilagrow @w84thesun @rumyantseva @noisersup @AlekSi