Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iterator in $sum aggregation accumulator #2799

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 6, 2023

Description

Closes #2706.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jun 6, 2023
@chilagrow chilagrow added code/chore Code maintenance improvements area/aggregations Issues about aggregation pipelines labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2799 (469fb1a) into main (834d75b) will decrease coverage by 37.11%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2799       +/-   ##
===========================================
- Coverage   63.82%   26.71%   -37.11%     
===========================================
  Files         442      442               
  Lines       22520    22519        -1     
===========================================
- Hits        14373     6016     -8357     
- Misses       7208    15886     +8678     
+ Partials      939      617      -322     
Impacted Files Coverage Δ
.../common/aggregations/operators/accumulators/sum.go 0.00% <0.00%> (-95.41%) ⬇️

... and 143 files with indirect coverage changes

Flag Coverage Δ
integration 5.00% <0.00%> (-51.86%) ⬇️
mongodb 5.00% <0.00%> (+<0.01%) ⬆️
pg ?
unit 25.19% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup June 6, 2023 08:04
@chilagrow chilagrow marked this pull request as ready for review June 6, 2023 08:05
@chilagrow chilagrow requested a review from a team as a code owner June 6, 2023 08:05
@chilagrow chilagrow enabled auto-merge (squash) June 6, 2023 08:05
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 1bfc450 into FerretDB:main Jun 7, 2023
@AlekSi AlekSi added this to the v1.4.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aggregations Issues about aggregation pipelines code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make $sum aggregation accumulator use iterator properly
4 participants