Remove findAndModify integration tests with $ prefixed key for MongoDB 6.0.6 compatibility
#2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
===========================================
- Coverage 62.93% 26.06% -36.88%
===========================================
Files 441 441
Lines 22737 22737
===========================================
- Hits 14310 5926 -8384
- Misses 7497 16201 +8704
+ Partials 930 610 -320 see 144 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
changed the title
findAndModify integration tests with $ prefixed key for MongoDB 6.0.6findAndModify integration tests with $ prefixed key for MongoDB 6.0.6 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2736.
Previous PR #2779 actually did not fix it for MongoDB 6.0.6. See #2727.
$prefixed keys are valid in MongoDB 6.0.6. Let's remove those tests, we have diff documented in https://github.com/FerretDB/FerretDB/blob/main/website/docs/diff.md?plain=1#L19.findandmodifydollar prefixed field name dance#466Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.