Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix free monitoring tests for MongoDB 6.0.6 #2784

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Fix free monitoring tests for MongoDB 6.0.6 #2784

merged 7 commits into from
Jun 7, 2023

Conversation

jeremyphua
Copy link
Contributor

Description

Closes #2735.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@jeremyphua jeremyphua requested a review from a team as a code owner June 4, 2023 04:43
@jeremyphua jeremyphua requested review from AlekSi and rumyantseva June 4, 2023 04:43
chilagrow
chilagrow reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about this, thanks for the contribution!

integration/commands_freemonitoring_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi removed their request for review June 5, 2023 14:41
@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #2784 (048fc2d) into main (c6685e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2784   +/-   ##
=======================================
  Coverage   63.81%   63.81%           
=======================================
  Files         442      442           
  Lines       22519    22519           
=======================================
  Hits        14370    14370           
  Misses       7210     7210           
  Partials      939      939
Flag Coverage Δ
integration 56.85% <ø> (ø)
mongodb 5.00% <ø> (ø)
pg 56.76% <ø> (ø)
unit 25.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva requested a review from chilagrow June 5, 2023 15:41
@AlekSi AlekSi added this to the Next milestone Jun 6, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 6, 2023
@AlekSi AlekSi mentioned this pull request Jun 6, 2023
Merged
9 tasks
chilagrow
chilagrow previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks again for your contribution 🚀

@chilagrow chilagrow enabled auto-merge (squash) June 7, 2023 00:07
rumyantseva
rumyantseva previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow dismissed stale reviews from rumyantseva and themself via 6a5728d June 7, 2023 08:46
rumyantseva
rumyantseva previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow merged commit 1b7ff7e into FerretDB:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@jeremyphua jeremyphua

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Fix free monitoring tests for MongoDB 6.0.6
4 participants
@jeremyphua @rumyantseva @chilagrow @AlekSi