Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testDistinctCompat #2782

Merged
merged 14 commits into from
Jun 6, 2023
Merged

Improve testDistinctCompat #2782

merged 14 commits into from
Jun 6, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 2, 2023 •
edited
Loading

Description

Closes #2167.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 2, 2023
@noisersup noisersup self-assigned this Jun 2, 2023
@noisersup noisersup added the code/chore Code maintenance improvements label Jun 2, 2023
@noisersup noisersup removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 5, 2023
@noisersup noisersup marked this pull request as ready for review June 5, 2023 12:55
@noisersup noisersup requested a review from a team as a code owner June 5, 2023 12:55
@noisersup noisersup requested review from rumyantseva, chilagrow, a team and w84thesun June 5, 2023 12:55
@noisersup noisersup enabled auto-merge (squash) June 5, 2023 12:55
@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #2782 (1e08c3c) into main (5c38501) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2782   +/-   ##
=======================================
  Coverage   26.71%   26.71%           
=======================================
  Files         442      442           
  Lines       22520    22520           
=======================================
  Hits         6016     6016           
  Misses      15887    15887           
  Partials      617      617
Flag Coverage Δ
integration 5.00% <ø> (ø)
mongodb 5.00% <ø> (ø)
unit 25.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva reviewed Jun 5, 2023
View reviewed changes
integration/helpers.go Outdated Show resolved Hide resolved
chilagrow
chilagrow reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @rumyantseva's comment too 🤗

integration/distinct_test.go Outdated Show resolved Hide resolved
@noisersup
Copy link
Member Author

@chilagrow @rumyantseva I've simplified the test to as minimal as possible. Now we know that numeric values are merged with each other but numerical strings are not.

@noisersup noisersup requested a review from rumyantseva June 6, 2023 10:56
rumyantseva
rumyantseva approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noisersup noisersup merged commit 834d75b into FerretDB:main Jun 6, 2023
@noisersup noisersup deleted the improve-testdistinct-2167 branch June 6, 2023 14:05
@AlekSi AlekSi added this to the v1.4.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Improve testDistinctCompat
5 participants
@noisersup @w84thesun @rumyantseva @chilagrow @AlekSi