Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findAndModify tests for MongoDB 6.0.6 #2779

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix findAndModify tests for MongoDB 6.0.6 #2779

merged 1 commit into from
Jun 2, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 2, 2023 •
edited
Loading

Description

Closes #2736.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jun 2, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jun 2, 2023
@chilagrow chilagrow changed the title fix find and modify test for Mongo 6.0.6 Fix findAndModify tests for MongoDB 6.0.6 Jun 2, 2023
@chilagrow chilagrow marked this pull request as ready for review June 2, 2023 09:59
@chilagrow chilagrow requested a review from a team as a code owner June 2, 2023 09:59
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, w84thesun and noisersup June 2, 2023 09:59
@chilagrow chilagrow enabled auto-merge (squash) June 2, 2023 10:00
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #2779 (2cacaa2) into main (4fae741) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   63.01%   63.01%           
=======================================
  Files         441      441           
  Lines       22689    22689           
=======================================
  Hits        14297    14297           
  Misses       7461     7461           
  Partials      931      931
Flag Coverage Δ
integration 56.48% <ø> (-0.05%) ⬇️
mongodb 4.95% <ø> (ø)
pg 56.39% <ø> (-0.05%) ⬇️
unit 24.58% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Jun 2, 2023
noisersup
noisersup approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

w84thesun
w84thesun approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 1d6997b into FerretDB:main Jun 2, 2023
@chilagrow chilagrow mentioned this pull request Jun 5, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Fix findAndModify tests for MongoDB 6.0.6
4 participants
@chilagrow @w84thesun @noisersup @AlekSi