Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to call DeepCopy in some places #2774

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 2, 2023

Description

Closes #2754.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 2, 2023
@AlekSi AlekSi added this to the Next milestone Jun 2, 2023
@AlekSi AlekSi self-assigned this Jun 2, 2023
@AlekSi AlekSi marked this pull request as ready for review June 2, 2023 05:46
@AlekSi AlekSi requested a review from a team as a code owner June 2, 2023 05:46
@AlekSi AlekSi requested review from w84thesun and rumyantseva June 2, 2023 05:46
@AlekSi AlekSi enabled auto-merge (squash) June 2, 2023 05:47
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 2, 2023
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 2, 2023 05:47
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2774 (73974c7) into main (40fa532) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
+ Coverage   63.03%   63.04%   +0.01%     
==========================================
  Files         441      441              
  Lines       22643    22638       -5     
==========================================
  Hits        14272    14272              
+ Misses       7443     7437       -6     
- Partials      928      929       +1     
Impacted Files Coverage Δ
internal/handlers/pg/msg_insert.go 84.11% <ø> (-0.44%) ⬇️
internal/handlers/tigris/msg_insert.go 0.00% <ø> (ø)
internal/clientconn/conn.go 53.15% <75.00%> (+0.65%) ⬆️
Flag Coverage Δ
integration 56.49% <75.00%> (+0.01%) ⬆️
mongodb 4.96% <0.00%> (+<0.01%) ⬆️
pg 56.41% <75.00%> (+0.01%) ⬆️
unit 24.64% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@AlekSi AlekSi merged commit 70d692c into FerretDB:main Jun 2, 2023
@AlekSi AlekSi deleted the proxy branch June 2, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove DeepCopy
3 participants