-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement envtool tests shard
command
#2773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I have few comments. Let` me know if you need any help with this task 🤗
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
===========================================
- Coverage 63.81% 26.71% -37.10%
===========================================
Files 442 442
Lines 22519 22519
===========================================
- Hits 14370 6016 -8354
- Misses 7210 15886 +8676
+ Partials 939 617 -322 see 144 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi @chilagrow and @AlekSi, Could you please take look again? Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I have minor comments about linter warnings 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Being able to run subsets of tests like this is amazing 🤗
$ GOFLAGS="-run=$(go run ./cmd/envtool tests shard --index=0 --total=30) -parallel=1" task test-integration-pg
task: [test-integration-pg] go test -count=1 -timeout=35m -race=true -tags=ferretdb_debug,ferretdb_tigris,ferretdb_hana -shuffle=on -coverpkg=../... -coverprofile=integration-pg.txt . -target-backend=ferretdb-pg -target-tls -postgresql-url=postgres://username@127.0.0.1:5432/ferretdb -compat-url='mongodb://username:password@127.0.0.1:47018/?tls=true&tlsCertificateKeyFile=../build/certs/client.pem&tlsCaFile=../build/certs/rootCA-cert.pem'
ok github.com/FerretDB/FerretDB/integration 11.738s coverage: 40.0% of statements in ../...
Description
Closes #2692.
Implemented
envtool tests shard
command.go run ./cmd/envtool tests shard --index=0 --total=2
go test -run regexp="$(go run ../cmd/envtool tests shard --index=0 --total=2)"
- works in the integration folderReadiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.