Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger GC to run finalizers #2771

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Trigger GC to run finalizers #2771

merged 1 commit into from
Jun 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 1, 2023

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 1, 2023
@AlekSi AlekSi added this to the Next milestone Jun 1, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 1, 2023 20:02
@AlekSi AlekSi self-assigned this Jun 1, 2023
@AlekSi AlekSi requested review from w84thesun and chilagrow June 1, 2023 20:02
@AlekSi AlekSi enabled auto-merge (squash) June 1, 2023 20:02
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup June 1, 2023 20:02
w84thesun
w84thesun approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #2771 (084f2b3) into main (bddfa9e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
- Coverage   63.04%   63.03%   -0.02%     
==========================================
  Files         441      441              
  Lines       22639    22643       +4     
==========================================
  Hits        14272    14272              
- Misses       7439     7443       +4     
  Partials      928      928
Impacted Files Coverage Δ
integration/setup/startup.go 67.18% <0.00%> (-4.48%) ⬇️
Flag Coverage Δ
integration 56.48% <0.00%> (-0.02%) ⬇️
mongodb 4.96% <0.00%> (-0.01%) ⬇️
pg 56.40% <0.00%> (-0.02%) ⬇️
unit 24.64% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit c60534b into FerretDB:main Jun 2, 2023
@AlekSi AlekSi deleted the gc branch June 2, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @chilagrow