Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up lazyerrors, use them in more places #2770

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Clean-up lazyerrors, use them in more places #2770

merged 2 commits into from
Jun 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 1, 2023

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 1, 2023
@AlekSi AlekSi added this to the Next milestone Jun 1, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 1, 2023 19:56
@AlekSi AlekSi self-assigned this Jun 1, 2023
@AlekSi AlekSi requested review from w84thesun and rumyantseva June 1, 2023 19:56
@AlekSi AlekSi enabled auto-merge (squash) June 1, 2023 19:56
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 1, 2023 19:57
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #2770 (31a8375) into main (70d692c) will not change coverage.
The diff coverage is 29.41%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files         441      441           
  Lines       22638    22638           
=======================================
  Hits         5926     5926           
  Misses      16102    16102           
  Partials      610      610
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/pool.go 69.46% <0.00%> (ø)
internal/util/lazyerrors/lazyerrors.go 76.47% <100.00%> (ø)
Flag Coverage Δ
integration 4.96% <0.00%> (ø)
mongodb 4.96% <0.00%> (ø)
unit 24.64% <29.41%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clean up 🤗 . There is a linter warning

@AlekSi AlekSi requested review from chilagrow and a team June 2, 2023 04:56
rumyantseva
rumyantseva approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit ede2468 into FerretDB:main Jun 2, 2023
@AlekSi AlekSi deleted the lazy-errors branch June 2, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow