Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CountIterator #2759

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Simplify CountIterator #2759

merged 1 commit into from
Jun 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 1, 2023 •
edited
Loading

Description

No need to use atomics.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Simplify CountIterator
61fbdba 
No need to use atomics.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 1, 2023
@AlekSi AlekSi added this to the Next milestone Jun 1, 2023
@AlekSi AlekSi self-assigned this Jun 1, 2023
@AlekSi AlekSi marked this pull request as ready for review June 1, 2023 07:29
@AlekSi AlekSi requested a review from a team as a code owner June 1, 2023 07:29
@AlekSi AlekSi requested review from w84thesun and chilagrow June 1, 2023 07:29
@AlekSi AlekSi enabled auto-merge (squash) June 1, 2023 07:29
@AlekSi AlekSi requested review from noisersup and removed request for w84thesun June 1, 2023 07:29
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #2759 (61fbdba) into main (4a69d97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2759   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files         441      441           
  Lines       22633    22629    -4     
=======================================
- Hits        14274    14272    -2     
+ Misses       7434     7433    -1     
+ Partials      925      924    -1
Impacted Files Coverage Δ
internal/handlers/common/count_iterator.go 96.66% <100.00%> (+5.49%) ⬆️
Flag Coverage Δ
integration 56.52% <100.00%> (+<0.01%) ⬆️
mongodb 4.96% <0.00%> (+<0.01%) ⬆️
pg 56.43% <100.00%> (+<0.01%) ⬆️
unit 24.65% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request Jun 1, 2023
Merged
9 tasks
noisersup
noisersup approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@AlekSi AlekSi merged commit 14534a5 into FerretDB:main Jun 1, 2023
@AlekSi AlekSi deleted the count-iterator branch June 1, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup