Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test cases for index validation #2752

Merged
merged 17 commits into from
Jun 13, 2023
Merged

Add more test cases for index validation #2752

merged 17 commits into from
Jun 13, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 31, 2023 •
edited
Loading

Description

Closes #2311.

This PR adds more test cases for #2311, it doesn't fix the issue itself, it only provides the necessary test cases (analysis phase).

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this May 31, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #2752 (79d90ed) into main (513efa6) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   63.80%   63.81%   +0.01%     
==========================================
  Files         442      442              
  Lines       22529    22527       -2     
==========================================
+ Hits        14374    14376       +2     
+ Misses       7216     7212       -4     
  Partials      939      939
Impacted Files Coverage Δ
internal/handlers/pg/msg_createindexes.go 76.77% <ø> (+0.72%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.86% <ø> (+0.01%) ⬆️
mongodb 5.03% <ø> (+<0.01%) ⬆️
pg 56.77% <ø> (+0.01%) ⬆️
shard-1 43.44% <ø> (+0.92%) ⬆️
shard-2 44.02% <ø> (-0.61%) ⬇️
shard-3 42.45% <ø> (-0.11%) ⬇️
unit 25.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 2, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 6, 2023
@rumyantseva rumyantseva requested review from a team, w84thesun, chilagrow and noisersup June 7, 2023 08:09
@rumyantseva rumyantseva marked this pull request as ready for review June 7, 2023 08:09
@rumyantseva rumyantseva requested a review from a team as a code owner June 7, 2023 08:09
@rumyantseva rumyantseva enabled auto-merge (squash) June 7, 2023 08:09
noisersup
noisersup previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

w84thesun
w84thesun reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I asked the question about the TestIndexesDropRunCommand test cases.

integration/indexes_compat_test.go Outdated Show resolved Hide resolved
w84thesun
w84thesun reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I asked the question about the TestIndexesDropRunCommand test cases.

@rumyantseva rumyantseva requested a review from w84thesun June 7, 2023 09:48
w84thesun
w84thesun previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 7, 2023
chilagrow
chilagrow previously approved these changes Jun 8, 2023
View reviewed changes
@mergify mergify bot added the conflict PRs that have merge conflicts label Jun 8, 2023
@rumyantseva rumyantseva dismissed stale reviews from chilagrow, noisersup, and w84thesun via 4f41762 June 9, 2023 11:53
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jun 9, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 12, 2023
chilagrow
chilagrow previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

noisersup
noisersup previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva dismissed stale reviews from noisersup and chilagrow via 659fdfd June 12, 2023 13:12
@rumyantseva
Copy link
Contributor Author

@noisersup @chilagrow please review again! I fixed the error message in a couple of tests.

chilagrow
chilagrow approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rumyantseva rumyantseva merged commit 8ad2489 into FerretDB:main Jun 13, 2023
@rumyantseva rumyantseva deleted the issue-2311-idnex-validation branch June 13, 2023 06:41
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Implement proper validation for createIndexes and dropIndexes
5 participants
@rumyantseva @w84thesun @chilagrow @noisersup @AlekSi