Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call ListSpecifications driver's method in tests to check indexes #2746

Merged
merged 1 commit into from
May 31, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 31, 2023

Description

Closes #2332.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label May 31, 2023
@rumyantseva rumyantseva self-assigned this May 31, 2023
@rumyantseva rumyantseva changed the title CallListSpecifications driver's method in tests to check indexes Call ListSpecifications driver's method in tests to check indexes May 31, 2023
@rumyantseva rumyantseva marked this pull request as ready for review May 31, 2023 10:26
@rumyantseva rumyantseva requested a review from a team as a code owner May 31, 2023 10:26
@rumyantseva rumyantseva requested review from AlekSi and chilagrow May 31, 2023 10:26
@rumyantseva rumyantseva enabled auto-merge (squash) May 31, 2023 10:26
@rumyantseva rumyantseva requested review from a team, w84thesun and noisersup May 31, 2023 10:26
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2746 (676dbf6) into main (d58fb17) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2746   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files         441      441           
  Lines       22619    22619           
=======================================
  Hits        14260    14260           
  Misses       7434     7434           
  Partials      925      925           
Flag Coverage Δ
integration 56.49% <ø> (ø)
mongodb 4.96% <ø> (ø)
pg 56.40% <ø> (ø)
unit 24.66% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rumyantseva rumyantseva merged commit ad0e824 into FerretDB:main May 31, 2023
@rumyantseva rumyantseva deleted the issue-2332-indexes-specs branch May 31, 2023 13:47
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test how driver's Indexes().ListSpecifications() method works with FerretDB
4 participants