Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat and lint more documentation files #2740

Merged
merged 6 commits into from
May 30, 2023
Merged

Reformat and lint more documentation files #2740

merged 6 commits into from
May 30, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 30, 2023 •
edited
Loading

Description

Closes #2738.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 30, 2023
@AlekSi AlekSi added this to the Next milestone May 30, 2023
@AlekSi AlekSi self-assigned this May 30, 2023
@AlekSi AlekSi changed the title Reformat and lint CHANGELOG.md Reformat and lint CHANGELOG.md May 30, 2023
@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 30, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 30, 2023
@AlekSi AlekSi changed the title Reformat and lint CHANGELOG.md Reformat and lint more documentation files May 30, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 30, 2023
@AlekSi AlekSi marked this pull request as ready for review May 30, 2023 15:41
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners May 30, 2023 15:41
@AlekSi AlekSi requested review from w84thesun and rumyantseva May 30, 2023 15:41
@AlekSi AlekSi enabled auto-merge (squash) May 30, 2023 15:41
@AlekSi AlekSi requested review from a team, chilagrow, noisersup and Fashander May 30, 2023 15:41
rumyantseva
rumyantseva approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2740 (474d247) into main (f988145) will decrease coverage by 36.85%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2740       +/-   ##
===========================================
- Coverage   63.04%   26.19%   -36.85%     
===========================================
  Files         441      441               
  Lines       22619    22619               
===========================================
- Hits        14260     5926     -8334     
- Misses       7434    16087     +8653     
+ Partials      925      606      -319
Impacted Files Coverage Δ
internal/handlers/common/update_params.go 0.00% <ø> (-100.00%) ⬇️

... and 144 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <ø> (-51.53%) ⬇️
mongodb 4.96% <ø> (ø)
pg ?
unit 24.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi disabled auto-merge May 30, 2023 16:20
@AlekSi AlekSi merged commit e4b2185 into FerretDB:main May 30, 2023
@AlekSi AlekSi deleted the format-changelog branch May 30, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@Fashander Fashander Awaiting requested review from Fashander Fashander was automatically assigned from FerretDB/docs

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Find linter for forbidding Unicode quotes
3 participants
@AlekSi @w84thesun @rumyantseva