Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testFindAndModifyCompat work with compatTestCaseResultType #2739

Merged
merged 9 commits into from
May 31, 2023
Merged

Make testFindAndModifyCompat work with compatTestCaseResultType #2739

merged 9 commits into from
May 31, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 30, 2023 •
edited
Loading

Description

Closes #2734.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 30, 2023
@rumyantseva rumyantseva self-assigned this May 30, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 30, 2023
@rumyantseva rumyantseva requested review from a team, w84thesun, chilagrow and noisersup May 30, 2023 17:11
@rumyantseva rumyantseva marked this pull request as ready for review May 30, 2023 17:11
@rumyantseva rumyantseva requested a review from a team as a code owner May 30, 2023 17:11
@rumyantseva rumyantseva enabled auto-merge (squash) May 30, 2023 17:11
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #2739 (e3b298a) into main (e4b2185) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2739   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files         441      441           
  Lines       22619    22619           
=======================================
  Hits        14260    14260           
  Misses       7434     7434           
  Partials      925      925
Flag Coverage Δ
integration 56.49% <ø> (ø)
mongodb 4.96% <ø> (ø)
pg 56.40% <ø> (ø)
unit 24.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestFindAndModifyCompatUpsertSet/UpsertID failed with expected non-empty results

@rumyantseva
Copy link
Contributor Author

@w84thesun ah, thanks for checking! I haven't pushed the code 😅

@rumyantseva rumyantseva requested a review from w84thesun May 31, 2023 07:29
@rumyantseva rumyantseva merged commit a972336 into FerretDB:main May 31, 2023
@rumyantseva rumyantseva deleted the issue-2734-test-results branch May 31, 2023 08:16
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Make testFindAndModifyCompat work with compatTestCaseResultType
4 participants
@rumyantseva @w84thesun @chilagrow @AlekSi