Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve authentication documentation #2737

Merged
merged 27 commits into from
Jun 5, 2023
Merged

Improve authentication documentation #2737

merged 27 commits into from
Jun 5, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented May 30, 2023 •
edited
Loading

Description

Closes #2663.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #2737 (9a447e2) into main (90a70a1) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2737   +/-   ##
=======================================
  Coverage   26.04%   26.04%           
=======================================
  Files         441      441           
  Lines       22737    22737           
=======================================
  Hits         5921     5921           
  Misses      16205    16205           
  Partials      611      611
Impacted Files Coverage Δ
internal/handlers/pg/msg_saslstart.go 0.00% <0.00%> (ø)
Flag Coverage Δ
integration 4.94% <0.00%> (ø)
mongodb 4.94% <0.00%> (ø)
unit 24.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone May 30, 2023
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label May 30, 2023
@chilagrow chilagrow added trust PRs that can access Actions secrets do not merge PRs that should not be merged and removed do not merge PRs that should not be merged labels Jun 1, 2023
@chilagrow chilagrow had a problem deploying to cloudflare-dev-docs June 1, 2023 08:25 — with GitHub Actions Failure
@chilagrow chilagrow had a problem deploying to cloudflare-dev-docs June 1, 2023 09:52 — with GitHub Actions Failure
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup June 1, 2023 10:06
@chilagrow chilagrow marked this pull request as ready for review June 1, 2023 10:06
@chilagrow chilagrow enabled auto-merge (squash) June 1, 2023 10:06
@AlekSi AlekSi temporarily deployed to cloudflare-dev-docs June 5, 2023 09:21 — with GitHub Actions Inactive
@AlekSi AlekSi requested a review from a team as a code owner June 5, 2023 10:29
@AlekSi AlekSi requested a review from rumyantseva June 5, 2023 10:29
AlekSi
AlekSi previously approved these changes Jun 5, 2023
View reviewed changes
@AlekSi AlekSi requested a review from Fashander June 5, 2023 11:11
Fashander
Fashander reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment for the page - tls.md

rumyantseva
rumyantseva previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks clear to me!

Fashander
Fashander previously approved these changes Jun 5, 2023
View reviewed changes
@AlekSi AlekSi dismissed stale reviews from Fashander, rumyantseva, and themself via 9a447e2 June 5, 2023 12:03
@AlekSi AlekSi requested a review from Fashander June 5, 2023 12:04
@AlekSi AlekSi disabled auto-merge June 5, 2023 12:14
@AlekSi AlekSi merged commit 4db2ad0 into FerretDB:main Jun 5, 2023
@chilagrow
Copy link
Member Author

Thank you for handling this 🤗 Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva rumyantseva left review comments

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@chilagrow chilagrow

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Improve authentication documentation
4 participants
@chilagrow @AlekSi @rumyantseva @Fashander