Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace document slices with iterators #2730

Merged
merged 19 commits into from
Jun 2, 2023
Merged

Replace document slices with iterators #2730

merged 19 commits into from
Jun 2, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented May 29, 2023 •
edited
Loading

Description

Closes #2723.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 29, 2023
AlekSi
AlekSi reviewed May 30, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we already made changes in count, and they work, let's keep them

@noisersup noisersup removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #2730 (2c3b544) into main (96858fd) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
- Coverage   26.13%   26.09%   -0.05%     
==========================================
  Files         441      441              
  Lines       22653    22689      +36     
==========================================
  Hits         5921     5921              
- Misses      16121    16157      +36     
  Partials      611      611
Impacted Files Coverage Δ
internal/handlers/common/distinct.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_count.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_distinct.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_distinct.go 0.00% <0.00%> (ø)
Flag Coverage Δ
integration 4.95% <0.00%> (-0.01%) ⬇️
mongodb 4.95% <0.00%> (-0.01%) ⬇️
unit 24.56% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/chore Code maintenance improvements label May 31, 2023
@noisersup noisersup requested review from a team, w84thesun, rumyantseva and chilagrow May 31, 2023 15:38
@noisersup noisersup marked this pull request as ready for review May 31, 2023 15:38
@noisersup noisersup requested a review from a team as a code owner May 31, 2023 15:38
@noisersup noisersup enabled auto-merge (squash) May 31, 2023 15:38
@noisersup noisersup requested a review from AlekSi May 31, 2023 15:39
rumyantseva
rumyantseva reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a few questions.

internal/handlers/pg/msg_count.go Outdated Show resolved Hide resolved
internal/handlers/pg/msg_distinct.go Outdated Show resolved Hide resolved
internal/handlers/pg/msg_distinct.go Outdated Show resolved Hide resolved
internal/handlers/pg/msg_distinct.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from rumyantseva May 31, 2023 18:36
chilagrow
chilagrow reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments 🤗

internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Jun 1, 2023
View reviewed changes
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
internal/handlers/common/distinct_iterator.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jun 1, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jun 1, 2023
@noisersup noisersup requested review from AlekSi and chilagrow June 1, 2023 12:57
rumyantseva
rumyantseva approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/handlers/tigris/msg_distinct.go Show resolved Hide resolved
chilagrow
chilagrow approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@AlekSi AlekSi added this to the Next milestone Jun 2, 2023
@noisersup noisersup merged commit 325c19c into FerretDB:main Jun 2, 2023
@noisersup noisersup deleted the more-iterators-2723 branch June 2, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Use iterators in distinct command
5 participants
@noisersup @AlekSi @w84thesun @rumyantseva @chilagrow