Don't use sjson.GetTypeOfValue where it shouldn't be used
#2728
Conversation
noisersup
requested review from
AlekSi,
rumyantseva,
a team,
w84thesun and
chilagrow
There was a problem hiding this comment.
They happen to do the same thing.
sjson layer is responsible for preserving BSON-type information in storage. Currently, we store type information in the special schema field. For example, for "64-bit binary floating point" value, we store a string "double". That string could be replaced with a number or even a bitmask as long as we preserve backward compatibility for client applications (and not even that if we bump a major version).
Type aliases are fixed and cannot be changed without breaking compatibility with MongoDB.
What we need to do instead is:
- make this difference clear from code doc comments;
- check that we don't use a wrong function somewhere (spoiler: we do at least in once place)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
===========================================
- Coverage 63.04% 26.19% -36.85%
===========================================
Files 441 441
Lines 22619 22619
===========================================
- Hits 14260 5926 -8334
- Misses 7434 16087 +8653
+ Partials 925 606 -319
... and 143 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
force-pushed
the
remove-gettypeofvalue
branch
from
c413615 to
99f1842
Compare
noisersup
changed the title
sjson.GetTypeOfValue helpersjson.GetTypeOfValue where it shouldn't be used
Description
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.