Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logout test for all backend #2726

Merged
merged 4 commits into from
May 29, 2023
Merged

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented May 29, 2023

Description

Closes #1750.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow changed the title Add logout test for non-TLS users Add logout test for non-TLS user May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2726 (f0e0159) into main (3d14095) will decrease coverage by 36.80%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2726       +/-   ##
===========================================
- Coverage   63.03%   26.23%   -36.80%     
===========================================
  Files         441      441               
  Lines       22612    22612               
===========================================
- Hits        14253     5932     -8321     
- Misses       7434    16073     +8639     
+ Partials      925      607      -318     

see 145 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <ø> (-51.53%) ⬇️
mongodb 4.96% <ø> (ø)
pg ?
unit 24.70% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/chore Code maintenance improvements label May 29, 2023
@chilagrow chilagrow changed the title Add logout test for non-TLS user Add logout test for non-TLS user May 29, 2023
@chilagrow chilagrow changed the title Add logout test for non-TLS user Add logout test for all backend May 29, 2023
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup May 29, 2023 10:17
@chilagrow chilagrow marked this pull request as ready for review May 29, 2023 10:17
@chilagrow chilagrow requested a review from a team as a code owner May 29, 2023 10:17
@chilagrow chilagrow enabled auto-merge (squash) May 29, 2023 10:17
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop connectionStatus and use bson.D like we usually do

@chilagrow chilagrow requested a review from AlekSi May 29, 2023 10:47
@chilagrow
Copy link
Member Author

👋 @kropidlowsky
I added additional test for testing logout for already logged out users against all backend 🤗

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi added this to the Next milestone May 29, 2023
@chilagrow chilagrow merged commit ba0005b into FerretDB:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement logout command
3 participants